Skip to content

Updates for new MCP230xx #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2019
Merged

Updates for new MCP230xx #39

merged 3 commits into from
May 31, 2019

Conversation

caternuson
Copy link
Contributor

This updates the library to use the new MCP230xx refactor.
adafruit/Adafruit_CircuitPython_MCP230xx#11

@caternuson
Copy link
Contributor Author

I was able to test with a PID 292, but don't have one of the shield or hats with buttons.

@ecspresso
Copy link

@caternuson If you tell me what to do, I could test this with a hat (if needed).

@caternuson
Copy link
Contributor Author

HAT = Pi. Easiest way is to use git and grab the PR version of the code with this process:
https://help.github.com/en/articles/checking-out-pull-requests-locally
and then set your PYTHONPATH to point to that local directory.

@ladyada
Copy link
Member

ladyada commented May 31, 2019

@brentru will be testing!

@brentru
Copy link
Member

brentru commented May 31, 2019

@caternuson Did you update an example?

on this branch, I'm hitting against the No Module named error:

Traceback (most recent call last):
  File "code.py", line 15, in <module>
  File "/lib/adafruit_character_lcd/character_lcd_i2c.py", line 74, in __init__
ImportError: no module named 'adafruit_mcp230xx'

Example: https://github.com/adafruit/Adafruit_CircuitPython_CharLCD/blob/master/examples/charlcd_i2c_mono_simpletest.py

Board: Metro M4

@caternuson
Copy link
Contributor Author

The examples shouldn't need updating. Hopefully. The change is essentially just a tweak to the import syntax for the MCP230xx library which is done in the __init__ of the various classes.

Are you testing the PR version? That looks like the error you'd get if still using the current library.

@brentru
Copy link
Member

brentru commented May 31, 2019

@caternuson Yup, I'm testing the PR'd version.

@brentru
Copy link
Member

brentru commented May 31, 2019

@caternuson Works with a shield kit. You may want to add the MCP230xx library to the README's dependency list: https://github.com/adafruit/Adafruit_CircuitPython_CharLCD#dependencies

@brentru brentru merged commit 2b1dbc2 into adafruit:master May 31, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 1, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.2.1 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#39 from caternuson/iss36

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#5 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#6 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#3 from brentru/patch-return-message

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.9.1 from 0.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#14 from tannewt/move_tests
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#12 from crookedstorm/feature-tests
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#13 from matt-land/bugfix-fix-the-build-sphinx
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#7 from tannewt/use_bitmap_subscr
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#11 from crookedstorm/docs-add-development-guide

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 2.0.0 from 1.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#30 from adafruit/revert-29-master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants